store: remove stale calendar events after date changes - #263
Closed
anish749 wants to merge 1 commit into
Closed
Conversation
anish749
commented
Apr 19, 2026
anish749
left a comment
Owner
Author
There was a problem hiding this comment.
Two issues to address:
-
Path construction belongs in paths module.
filepath.Join(ad.Path(), paths.GcalendarSubdir)indeduplicateCalendarEventsshould be a method onAccountDir(e.g.ad.GcalendarDir()returning the path), keeping the store layer free of path construction. Same layering rule as the rest of the codebase. -
"Latest" event version uses string comparison on
Runtime.Updated. This works for RFC 3339 timestamps lexicographically, but it's implicit. Consider parsing totime.Timefor the comparison, or at minimum add a comment explaining why string comparison is safe here. Also need to handle the case whereUpdatedis empty.
Owner
Author
|
Superseded by #266 which takes a cleaner reshuffle approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-file dedup pass for calendar events in Maintain.
When an event moves dates or a multi-day event shrinks, stale copies
linger in old date files. Scans all date files per calendar, picks the
most recently updated version of each event, and removes copies from
files outside the event's current DatesForStorage range.