oncetask: WithPollInterval option for consumer-loop poll cadence - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The consumer-loop idle-poll interval was hardcoded to 1 minute (
oncetask/once_task_firestore.go). That puts a 1-minute floor on how late a time-readied task (waitUntil expiry, retry backoff, recurrence occurrence) can fire relative to its scheduled time. Workloads that need lower latency had no knob.Solution
Add
WithPollInterval(d time.Duration) HandlerOption. Stored onhandlerConfig.PollInterval, defaults to 1 minute, non-positive values ignored. The consumer loop reads the value once at start when constructing its ticker.Context
Per-handler option, same pattern as
WithLeaseDuration/WithConcurrency. The value is read once atrunLoopstart — re-registration won't reset a live ticker, which matches howConcurrencyalready behaves (workers are spawned at registration). New-task creation continues to wake the loop immediately viaevaluateChan; the poll interval only governs the time-based fallback.