protocol: raise stream limit for messages over 64 KiB - #16
Merged
Conversation
asyncio StreamReader defaults to a 64 KiB buffer, so readline() raised ValueError on larger newline-delimited messages: exec responses carrying cell outputs on the client side, and large --file code payloads on the daemon side. Set a shared STREAM_LIMIT on both endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio's
StreamReaderdefaults to a 64 KiB buffer, soreadline()raisesValueError: Separator is not found, and chunk exceed the limiton any larger newline-delimited message. This hit both endpoints of the daemon protocol: exec responses carrying cell outputs failed on the client, and large--filecode payloads failed on the daemon, where the error was swallowed and surfaced as "daemon closed connection".Both endpoints now pass a shared
proto.STREAM_LIMITof 64 MiB. Added a round-trip test over a real unix socket that sends a 200 KiB request and reads back a larger response; it fails with the originalValueErrorwithout the fix.