exec: diagnose connection failures with server health checks - #15
Merged
Conversation
When the WebSocket connection to the Jupyter server drops, the CLI previously showed a generic "Connection is already closed." error. Now, connection-related exceptions trigger an HTTP health check against the server to report whether the server is unreachable, the kernel has been shut down, or the WebSocket dropped while the kernel is still running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the WebSocket connection to the Jupyter server drops (VPN disconnect, network interruption, proxy timeout, kernel shutdown), the CLI shows a generic
"Connection is already closed."error from the websocket library. The caller has no way to tell what actually happened.Solution
Added a diagnostics module (
session/diagnostics.py) that:The
Session.execute()exception handler now uses these diagnostics for connection failures, while non-connection errors (e.g. kernel code exceptions) continue to pass through unchanged.