Fix Arabic RTL layout and shaping in Cairo UI rendering#76
Open
SaudMD wants to merge 1 commit into
Open
Conversation
|
Hello! Sorry about the delay in looking at this, things have been busy lately. Is it possible to show a before and after of what the changes look like from this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves Arabic UI rendering in the Cairo text pipeline.
Arabic text was previously shown with disconnected letters, incorrect right-to-left ordering, and inconsistent mixed Arabic/Latin layout in several client UI screens. This change adds contextual Arabic shaping and visual RTL preparation before text measurement and drawing, then routes the relevant UI rendering paths through that logic.
What Changed
ComplexTextLayoutto prepare RTL text before rendering.لا,لأ,لإ, andلآ.CairoFont.CairoGlyphLayoutas an optional native glyph path, but kept it disabled because the current runtime resolves glyph indices without performing Arabic shaping correctly.Files
Client/UI/ComplexTextLayout.csClient/UI/CairoFont.csClient/UI/CairoGlyphLayout.csClient/UI/TextDrawUtil.csClient/UI/TextTextureUtil.csClient/UI/Elements/Impl/Interactive/Controls/GuiElementHorizontalTabs.csClient/UI/Elements/Impl/Interactive/Controls/GuiElementVerticalTabs.csTesting
Tested on Windows with the built
VintagestoryAPI.dllinstalled into the game.Verified manually in:
Confirmed outcomes:
Simplified Arabicin the tested Windows setupNotes