Since some modern browers sometimes don't support Promise, change Pro…#28
Open
sparklxb wants to merge 1 commit into
Open
Since some modern browers sometimes don't support Promise, change Pro…#28sparklxb wants to merge 1 commit into
sparklxb wants to merge 1 commit into
Conversation
|
+1 !! I'm facing Promise errors with IE 11 right now. |
|
👍 @andyshora I actually don't see any compelling reason to not use $q, being an Angular directive and all eh? |
blavenie
added a commit
to duniter-cesium/angular-image-crop
that referenced
this pull request
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some modern browers sometimes don't support Promise, change from JS Promise to Angular $q can help enhance compatibility.