Package the reviewed ADHD Codex adapter - #1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5926e4d68b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if in_policy and stripped.startswith("allow_implicit_invocation:"): | ||
| values.append(stripped.split(":", 1)[1].strip().split(" #", 1)[0]) |
There was a problem hiding this comment.
If allow_implicit_invocation is accidentally nested under another policy key, this indentation-insensitive scan still accepts the file; for example, policy: {nested: {allow_implicit_invocation: false}} passes this CI validator even though Codex no longer sees the required policy.allow_implicit_invocation: false setting. Since explicit-only activation is a load-bearing package contract, validate the parsed YAML structure and boolean value rather than matching any descendant line.
Useful? React with 👍 / 👎.
| r"^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)" | ||
| r"(?:-[0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*)?" | ||
| r"(?:\+[0-9A-Za-z-]+(?:\.[0-9A-Za-z-]+)*)?$" |
There was a problem hiding this comment.
When a future package version contains a numeric prerelease identifier with a leading zero, such as 1.2.3-01 or 1.2.3-alpha.01, this regex accepts it even though strict Semantic Versioning rejects it and the Codex ingestion validator enforces that restriction. CI would therefore report a malformed manifest as valid until marketplace ingestion fails.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation