Support DTS Express in Matroska#3226
Merged
Merged
Conversation
FFmpeg outputs DTS Express files with "DTS" codec ID, so we need to add it to the detection. That however is free because we must do the detection anyway for DTS-HD, and we can even reuse all the code needed for TS logic. This is also a building block for a future commit detecting DTS-HD MA, and the util method is useful for a future commit for the MP4 extractor.
rohitjoins
force-pushed
the
dtsexpressinmkv
branch
from
84940fa to
68f18c8
Compare
|
@nift4 I hope that future versions of DTS-MA can be changed like this. |
Contributor
Author
|
@FongMi Yes, I'll do it once DTS Express is taken care of for MP4 and MKV. The reason is that changing this to a new MIME type will need some care in order to not break passthrough for Android TV devices, so I think it will be easier to review if it's seperated from the changes that are for DTS Express. |
|
@nift4 thanks, |
Contributor
Author
|
Thanks again @rohitjoins, I've uploaded the last shard of my original PR: #3229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FFmpeg outputs DTS Express files with "DTS" codec ID, so we need to add it to the detection. That however is free because we must do the detection anyway for DTS-HD, and we can even reuse all the code needed for TS logic.
This is also a building block for a future commit detecting DTS-HD MA, and the util method is useful for a future commit for the MP4 extractor.