Sync changes from internal dev branch.#92
Conversation
PiperOrigin-RevId: 904494095
PiperOrigin-RevId: 904516222
PiperOrigin-RevId: 904713390
PiperOrigin-RevId: 904715961
PiperOrigin-RevId: 904720856
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the configuration parameter ignore_indoor_5g_test_for_china_ap to ignore_indoor_5g_test_for_china_triband_ap to clarify that it specifically applies to China tri-band APs and their incompatibility with Japan devices on the UNII-3 band. Review feedback highlights that this is a breaking change for existing configurations and recommends maintaining backward compatibility by keeping the old field as a deprecated alias and updating the test logic to check both parameters.
| ignore_indoor_5g_test_for_china_ap: bool = False | ||
| # Ignore the indoor 5g test for China tri-band AP, as China tri-band AP only | ||
| # can use UNII-3 band for 5G wifi, which is not supported by Japan devices. | ||
| ignore_indoor_5g_test_for_china_triband_ap: bool = False |
There was a problem hiding this comment.
Renaming ignore_indoor_5g_test_for_china_ap to ignore_indoor_5g_test_for_china_triband_ap is a breaking change for existing test configurations. Since from_user_params dynamically maps user parameters to dataclass fields, any configuration using the old name will now be ignored, and the test will default to False (not ignored). Consider maintaining backward compatibility by keeping the old field as a deprecated alias.
| ignore_indoor_5g_test_for_china_triband_ap: bool = False | |
| ignore_indoor_5g_test_for_china_triband_ap: bool = False | |
| # Deprecated: use ignore_indoor_5g_test_for_china_triband_ap instead. | |
| ignore_indoor_5g_test_for_china_ap: bool = False |
| asserts.skip_if( | ||
| self.test_parameters.ignore_indoor_5g_test_for_china_ap, | ||
| 'Skip indoor 5g test for China AP', | ||
| self.test_parameters.ignore_indoor_5g_test_for_china_triband_ap, |
There was a problem hiding this comment.
To support backward compatibility with existing configurations that still use the old parameter name, consider checking both the new and the deprecated flags.
| self.test_parameters.ignore_indoor_5g_test_for_china_triband_ap, | |
| self.test_parameters.ignore_indoor_5g_test_for_china_triband_ap or self.test_parameters.ignore_indoor_5g_test_for_china_ap, |
2 participants
No description provided.