Conversation
kaishi05
approved these changes
Apr 9, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 2.6.4 and adds a corresponding entry to the CHANGELOG. However, the changelog entry stating the replacement of scc_2g_wfd_sta_test with xcc_2g_wfd_sta_test is noted as potentially inaccurate, as the BetoCqPerformanceTestSuite still appears to use the old test name.
| # BetoCQ test suite release history | ||
| ## 2.6.4 (04/08/2026) | ||
| ### Bug fixes | ||
| * Replace scc_2g_wfd_sta_test with xcc_2g_wfd_sta_test. |
Contributor
There was a problem hiding this comment.
This changelog entry appears to be inaccurate. The BetoCqPerformanceTestSuite in betocq/nearby_connection/betocq_test_suite.py still uses scc_2g_wfd_sta_test. The replacement with xcc_2g_wfd_sta_test mentioned here has not been applied to that test suite, which makes this changelog entry misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.