Fix artifact previews across granted roots#225
Open
kudala-bharani wants to merge 1 commit into
Open
Conversation
kudala-bharani
marked this pull request as ready for review
July 27, 2026 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223
What changed
Why
Markdown artifact links could point to files the session was allowed to create, but the artifact API only searched the primary workspace. URL-encoded filenames could also fail to match the artifact list in the GUI.
Impact
Links such as
artifact:新闻摘要.mdnow open the preview when the file lives in a granted writable directory. Files in explicitly granted read-only directories remain previewable by absolute path but are not presented as produced artifacts.Root cause
Artifact discovery and path resolution used a single workspace root instead of the session's live multi-root grant set. The GUI compared raw link paths without first decoding URL-encoded Unicode characters or normalizing path separators.
Validation
pytest -q— 890 passed, 1 skippedNODE_OPTIONS=--no-experimental-webstorage ./node_modules/.bin/vitest run— 72 passednpm run build— passedtsc --noEmit— passedgit diff --check— passed