fix: preserve exception chain in wait_dispatched timeout#222
Open
XinyuanWarms wants to merge 1 commit into
Open
fix: preserve exception chain in wait_dispatched timeout#222XinyuanWarms wants to merge 1 commit into
XinyuanWarms wants to merge 1 commit into
Conversation
Chain the original asyncio.TimeoutError via 'raise ... from exc' so __cause__ is retained, making flaky relay timeouts easier to debug. Fixes andrewyng#167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RelayHub.wait_dispatchedre-raised a freshTimeoutErrorwithout chaining it to the caughtasyncio.TimeoutError, so the original exception and its context were lost.as excandraise ... from excso__cause__is preserved, making flaky relay timeouts easier to debug.Fixes #167
Test plan
pytest tests/test_slack_relay.py— no new failures vs. baseline (the 4pre-existing timeouts are network/environment-related and unchanged by this fix)
TimeoutError.__cause__is now the originalasyncio.TimeoutError(it wasNonebefore)Before: