Add a builtin Sales persona (markdown manifest)#197
Open
ayobamiseun wants to merge 1 commit into
Open
Conversation
personas/builtin/ held a single manifest (ops.md) while the packaging glob,
registry loader, and docs all anticipate more ('Ops today; third-party dirs
in Phase 2'). This adds a Sales Coworker as pure manifest data — no engine
changes: prospect research, call-prep briefs, CRM hygiene, and outreach
drafting, with sending and CRM writes explicitly approval-gated in the
prompt.
Recommends real connectors (hubspot, gmail, google_calendar, apollo,
hunter) plus the salesforce placeholder, which the GUI renders as a brand
badge with a connect-to-enable state by design. Uses the same knowledge
toolset as Cowork/Ops and the 'table' glyph from the GUI's curated persona
icon set. Like every non-default persona it ships disabled — opt-in from
Settings > Personas — so a fresh install's picker is unchanged.
Tests mirror the Ops pattern: toolset equivalence with the Cowork builder,
plus a check that every recommended connector exists in the descriptor
catalog. Full backend suite: 891 passed, 1 skipped.
|
Cool idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a builtin Sales persona as a markdown manifest —
coworker/personas/builtin/sales.md— plus tests. Pure manifest data, zero engine changes: the registry already loads every*.mdinpersonas/builtin/(registry.py:157-159), the packaging glob already ships them, andregistry.py:5frames Ops as the first of more ("Ops today; third-party dirs in Phase 2").What the persona does: prospect research, call-prep briefs, CRM hygiene, and outreach/follow-up drafting. The system prompt hard-gates the consequential parts — outreach is never sent and CRM writes (stage, amount, owner) are never applied without explicit approval — and bans invented facts (names, titles, numbers) with a verified-vs-inferred distinction, since a wrong "fact" in front of a prospect is the worst failure mode for this persona.
Manifest choices, mapped to existing conventions:
tools: [files, search, shell, todo]— the same knowledge toolset as Cowork/Ops (verified by the toolset-equivalence test, same pattern as Ops').recommends: hubspot + gmail ascore; google_calendar, apollo, hunter asoptional— all real shipped connectors — plus thesalesforceplaceholder, which is exactly what placeholders are for perdescriptors.py:1030-1035(brand badge + "connect to enable", as Ops does with datadog/pagerduty).icon: table— from the GUI's curated named-glyph set for personas (personaIcon.tsx:20-36).registry.py:221-227), so a fresh install's picker is unchanged; users opt in from Settings ▸ Personas.Tests
Two additions to
tests/test_builtin_personas.py, mirroring the Ops pattern:test_sales_persona_composes_knowledge_toolset— resolves through the registry and asserts tool-name equivalence with thecowork_agent()builder plus family/messaging/connectors traits.test_sales_persona_recommends_only_cataloged_connectors— every recommended connector id exists inDESCRIPTORS, so the GUI can always render its badge.Verification
No GUI code touched — the persona renders through the same manifest path as Ops. Since it lands disabled, there is no visual change to a fresh install (the sidebar test asserting
["cowork"]still passes); the persona appears in Settings ▸ Personas exactly as Ops does, one row lower.Happy to adjust tone, connector picks, or the tier assignments if the team has a different vision for a Sales persona — I kept everything inside existing conventions so it's cheap to review.