fix: terminal launch failure (-1743)#69
Open
lynicis wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughOrchard declares its need to control Terminal through an Apple Events usage description and automation entitlement, with the changelog documenting the related Terminal and iTerm2 launch fix. ChangesTerminal automation permissions
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Fixes andrew-waters#64 by adding the com.apple.security.automation.apple-events entitlement and NSAppleEventsUsageDescription to Info.plist. This resolves the -1743 (errAEEventNotPermitted) error when trying to launch Terminal or iTerm2 using AppleScript.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Orchard/Info.plist`:
- Around line 12-13: Update the NSAppleEventsUsageDescription value in
Info.plist to mention both Terminal and iTerm2, or use wording that clearly
covers terminal applications, while preserving the existing explanation of
launching container shells.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 03c4a63d-4bcb-4df1-b137-f18f5e17571e
📒 Files selected for processing (2)
Orchard/Info.plistOrchard/Orchard.entitlements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes terminal launch failures (-1743
errAEEventNotPermitted) caused by missing Apple Events permissions on macOS Catalina and later. Hardened runtime applications require thecom.apple.security.automation.apple-eventsentitlement andNSAppleEventsUsageDescriptionstring inInfo.plistto send AppleEvents to other applications (like Terminal and iTerm2). Since both were missing, macOS automatically denied the AppleEvent request without showing a prompt.This PR adds:
com.apple.security.automation.apple-eventsentitlement toOrchard/Orchard.entitlements.NSAppleEventsUsageDescriptionkey toOrchard/Info.plistwith a clear explanation.Related issues
Closes #64
Screenshots / recording
N/A
Checklist
Orchardscheme)⌘U/xcodebuild test)CHANGELOG.md(Added / Changed / Fixed)