Add produce response reader/writer and wire server reply#15
Merged
Conversation
Implement the Produce response (v13, no tagged fields) and the response header in protocol.zig. Unlike the streamed request, the response carries only small metadata arrays, so it is modeled as a single nested data structure read/written at once: the reader allocates into a caller-provided allocator while the writer walks slices the caller holds. The server now sends a placeholder success response after consuming a produce request, and the client reads and prints it. Round-trip tests cover each new reader/writer pair, mirroring the established approach. https://claude.ai/code/session_016KgxNkzJurTPrykzXzKJ2z
Collect the small request metadata (topic_ids and partition indices) while streaming the request, and reflect it in the response instead of using placeholder values. Record bytes are still drained a chunk at a time and never held in memory; only the metadata needed for the response is kept, in an arena freed once the response is written. The remaining per-partition fields stay as example results a real broker would compute. https://claude.ai/code/session_016KgxNkzJurTPrykzXzKJ2z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Produce response (v13, no tagged fields) and the response
header in protocol.zig. Unlike the streamed request, the response carries
only small metadata arrays, so it is modeled as a single nested data
structure read/written at once: the reader allocates into a caller-provided
allocator while the writer walks slices the caller holds.
The server now sends a placeholder success response after consuming a
produce request, and the client reads and prints it. Round-trip tests cover
each new reader/writer pair, mirroring the established approach.
https://claude.ai/code/session_016KgxNkzJurTPrykzXzKJ2z