Support IPv4-only, IPv6-only, and dual-stack hosts#14
Merged
Conversation
The server and example client both hardcoded the IPv6 loopback literal ::1:8080, which only works on hosts with an IPv6 stack and only over loopback. Server: bind the IPv6 wildcard (::), which on dual-stack Linux hosts is a dual-stack socket accepting both IPv6 and IPv4-mapped clients, and fall back to the IPv4 wildcard (0.0.0.0) when the host has no IPv6 stack. Client: resolve the host name via std's HostName.connect, letting the standard library race IPv6 and IPv4 candidates (Happy Eyeballs). On dual-stack hosts IPv6 is attempted first; IPv4-only hosts fall back transparently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server and example client both hardcoded the IPv6 loopback literal
::1:8080, which only works on hosts with an IPv6 stack and only over
loopback.
Server: bind the IPv6 wildcard (::), which on dual-stack Linux hosts is a
dual-stack socket accepting both IPv6 and IPv4-mapped clients, and fall
back to the IPv4 wildcard (0.0.0.0) when the host has no IPv6 stack.
Client: resolve the host name via std's HostName.connect, letting the
standard library race IPv6 and IPv4 candidates (Happy Eyeballs). On
dual-stack hosts IPv6 is attempted first; IPv4-only hosts fall back
transparently.