fix: @ApiSchema inheritance#259
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 38f0460
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There existed a bug in the
@nestjs/swaggerpackage where the@ApiSchemadecorator would not work as expected when applied to child classes (see issue 3160 for full details).This issue has been fixed (see PR 3164), however the patchNestjsSwagger function from this repo's
zod-nestjspackage overrides the fix with the old method of obtaining the schema name.This PR updates the patch function to obtain the schema name in the same way as the original function that is being patched.