Fix keyboard shortcuts and vault menu on Windows/Linux#104
Merged
Conversation
- titlebar.js parseShortcut: treat "cmd" as Ctrl on non-Mac (was requiring Meta/Win key, which users never press for shortcuts) - shortcut-runtime.js normalizeShortcutString: map "cmd" config prefix to "ctrl" on Windows/Linux so fallback shortcuts match key events - shortcut-runtime.js: remove Mac-only guard on core shortcut handler so Ctrl-based shortcuts fire on all platforms - shortcut-runtime.js: add stopImmediatePropagation to command palette handler to prevent double-fire with titlebar accelerator - titlebar.js buildMenuDef: add missing Credential Vault, Generate SSH Key, and Lock Vault items to the Tools menu
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 354452aef9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Addressed this by deduplicating plugin shortcut handling in custom-titlebar mode. What changed:
Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd+prefix which maps to Meta on macOS but was not being translated to Ctrl on Windows/Linux. Fixed in bothtitlebar.js(parseShortcut) andshortcut-runtime.js(normalizeShortcutString). Also removed the Mac-only guard on the core shortcut fallback handler.Ctrl+Shift+P, causing the palette to open then immediately close. AddedstopImmediatePropagation()to the shortcut-runtime handler.buildMenuDef()Tools menu.Test plan
Ctrl+T,Ctrl+W,Ctrl+Shift+N,Ctrl+Shift+M,Ctrl+Shift+Vand other shortcuts workCtrl+Shift+Popens/closes the command palette (no double-fire)