Fix test to account for gutenberg_render_layout_support_flag()#6850
Merged
Conversation
westonruter
added
the
Testing
Contributor
|
Plugin builds for 825a555 are ready 🛎️!
|
westonruter
added a commit
that referenced
this pull request
Jan 20, 2022
westonruter
added a commit
that referenced
this pull request
Jan 22, 2022
…r-amp-settings-panel * 'develop' of github.com:ampproject/amp-wp: Render value as fallback instead of entire parent source object Fix logic inversion for sources.length Ensure `sources` is non-empty array Revert "Ensure error `sources` is never `null`" Ensure error `sources` is never `null` Ensure `sources` is iterated over only if it is non-empty array Fix test to account for gutenberg_render_layout_support_flag() (#6850) Support converting YouTube iframes with 100% width to amp-youtube with fixed-height (#6837) Update Gutenberg package dependencies Update Gutenberg package dependencies Allow composer normalize plugin to run Normalize Composer file Update Composer to use AMP toolbox v0.10.0
westonruter
added
the
Changelogged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In WordPress/gutenberg#37360 the
gutenberg_render_layout_support_flag()function started injecting class names likewp-container-61e99d185b96fin the Columns block (as part of Gutenberg 12.3). This broke a unit test when for checking the expected output. So this PR just strips that class back out if it was added.Checklist