fix(flatfile): rename filatfile/amp.yml to flatfile/amp.yaml to match docs link#132
Merged
caiopizzol merged 1 commit intoMay 18, 2026
Conversation
The Flatfile sample was created under a typo'd directory name
('filatfile' instead of 'flatfile') with a .yml extension. The docs
guide at amp-labs/docs/src/provider-guides/flatfile.mdx links to
samples/blob/main/flatfile/amp.yaml, which currently returns 404
because the file is at /filatfile/amp.yml instead.
This rename moves the existing, well-formed Flatfile sample to the
path the docs already reference. No content changes.
Verified during investigation: the Flatfile connector connects with
an API-key auth scheme and proxies API calls end-to-end through
Ampersand. The existing manifest's specific read/write object claims
(events, jobs, environments, apps, spaces) were not exercised
end-to-end; this PR is a path correctness fix, not a re-validation
of the manifest's full contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Flatfile sample directory from the typo'd
filatfile/toflatfile/, and the file extension from.ymlto.yaml, so the path matches whatamp-labs/docs/src/provider-guides/flatfile.mdxalready links to.Today:
samples/filatfile/amp.ymlexists (HTTP 200)samples/flatfile/amp.yamlreturns 404 — the path the docs guide referencesAfter this PR, the docs link resolves. No content changes; pure path correction.
Verification
Git records this as a rename of the existing file at 100% similarity.
During investigation I also exercised the Flatfile API-key connection end-to-end against the Ampersand production API: a proxy
GET /v1/spacesthroughproxy.withampersand.comreturned the same response as a direct call toapi.x.flatfile.com/v1/spaces. That confirms the provider's connection + proxy flow works; it does not re-validate the specific read/write object claims in the manifest body. Those were not exercised here and are preserved as-is.Related