feat: add FourFour sample#119
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Ampersand sample configuration for the FourFour provider, defining scheduled read objects and enabling proxy support.
Changes:
- Introduces
fourfour/amp.yamlwith afourFour-readintegration definition. - Configures three read objects (
Chats,ChatMessages,Labels) with schedules, fields, and backfill behavior. - Enables proxy for the integration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| proxy: | ||
| enabled: true No newline at end of file |
There was a problem hiding this comment.
proxy is indented under read here, but in other samples it’s a sibling of read/write at the integration level. With the current indentation it will be parsed as read.proxy, which likely won’t be recognized by the amp schema. Outdent proxy: (and enabled:) to align with read:.
| proxy: | |
| enabled: true | |
| proxy: | |
| enabled: true |
| - fieldName: content | ||
| - fieldName: created_at | ||
| - fieldName: id |
There was a problem hiding this comment.
The requiredFields sequence items under ChatMessages aren’t indented under requiredFields:. In YAML, list items must be more indented than the mapping key, otherwise the file may be invalid or the fields won’t be associated with requiredFields. Indent the - fieldName: ... lines to match the pattern used for Chats above.
| - fieldName: content | |
| - fieldName: created_at | |
| - fieldName: id | |
| - fieldName: content | |
| - fieldName: created_at | |
| - fieldName: id |
|
|
||
| - objectName: ChatMessages | ||
| destination: fourFourWebhook | ||
| schedule: "*/10 * * * *" | ||
| # https://fourfour.ai/developers/api#tag/ChatMessages/paths/~1ChatMessages/get | ||
| requiredFields: | ||
| - fieldName: content | ||
| - fieldName: created_at | ||
| - fieldName: id | ||
| optionalFieldsAuto: all | ||
| backfill: | ||
| defaultPeriod: | ||
| fullHistory: true | ||
|
|
||
|
|
There was a problem hiding this comment.
There are trailing spaces on the - fieldName: id line, and there’s also inconsistent blank-line/whitespace usage in this block. Please trim trailing whitespace to avoid noisy diffs and formatter/linter issues.
| - objectName: ChatMessages | |
| destination: fourFourWebhook | |
| schedule: "*/10 * * * *" | |
| # https://fourfour.ai/developers/api#tag/ChatMessages/paths/~1ChatMessages/get | |
| requiredFields: | |
| - fieldName: content | |
| - fieldName: created_at | |
| - fieldName: id | |
| optionalFieldsAuto: all | |
| backfill: | |
| defaultPeriod: | |
| fullHistory: true | |
| - objectName: ChatMessages | |
| destination: fourFourWebhook | |
| schedule: "*/10 * * * *" | |
| # https://fourfour.ai/developers/api#tag/ChatMessages/paths/~1ChatMessages/get | |
| requiredFields: | |
| - fieldName: content | |
| - fieldName: created_at | |
| - fieldName: id | |
| optionalFieldsAuto: all | |
| backfill: | |
| defaultPeriod: | |
| fullHistory: true |
| - objectName: Chats | ||
| destination: fourFourWebhook | ||
| schedule: "*/10 * * * *" | ||
| # https://fourfour.ai/developers/api#tag/Chats/paths/~1Chats/get |
There was a problem hiding this comment.
The URL comment for the Chats object is less indented than the surrounding object properties, which makes the YAML harder to read and can look like it applies to a different level. Align the comment indentation with the other fields in the object block.
| # https://fourfour.ai/developers/api#tag/Chats/paths/~1Chats/get | |
| # https://fourfour.ai/developers/api#tag/Chats/paths/~1Chats/get |
No description provided.