[CON-3106] feat(fastSpring): New provider#543
Conversation
Cobalt0s
changed the title
Cobalt0s
left a comment
Cobalt0s
left a comment
There was a problem hiding this comment.
Once the deep connector is fully merged, tested and amp.yaml created then tag me I will review it one more time before merging.
Fullstack-Hero
changed the title
Fullstack-Hero
force-pushed
the
fastSpring
branch
from
c2ece86 to
3ff6e44
Compare
Cobalt0s
left a comment
Cobalt0s
left a comment
There was a problem hiding this comment.
Need some polishing. Refer to other providers that use API keys and how incremental read is documented in other docs. LiveStorm should be removed too.
Accidental duplicate content was included on the fastSpring branch; restore the file so the PR only contains FastSpring doc changes.
Fullstack-Hero
force-pushed
the
fastSpring
branch
from
fef78d6 to
a7b35b3
Compare
Cobalt0s
left a comment
Cobalt0s
left a comment
There was a problem hiding this comment.
LGTM
@RajatPawar I mentioned you in one of the comments, it would be helpful if you could advise on this.
|
|
||
| - **Read behavior**: [Read Actions](/read-actions) list supported object collections. The connector normalizes full-record and ID-only list responses into a consistent shape. Incremental read uses connector-side filtering on reads for all objects except those whose list responses do not expose fields the connector can rely on as a watermark—in those cases each scheduled read is a full read. | ||
| - **Write support**: `orders` and `subscriptions` support **update** only. All other writable objects (`accounts`, `products`) support create and update. Single-record operations only (no bulk write). | ||
| - **Commands**: FastSpring also exposes **command**-style operations (for example subscription cancel or product deactivation) that are not the same as creating or updating a record in a collection. They are not documented here as Write actions. See the [FastSpring API reference](https://developer.fastspring.com/reference/getting-started-with-your-api) for command endpoints, or use [Proxy Actions](/proxy-actions) to call them directly. |
There was a problem hiding this comment.
I would rephrase it somehow. Saying that something is not documented in this section is a bit contradictory, because you are mentioning it 😅 in the docs.
I am not sure myself, something that I came up with:
- **Commands**: FastSpring also exposes **command**-style operations (for example subscription cancel or product deactivation). These endpoints don't map "cleanly" to the Read/Write model. `Write` can still be used to invoke those commands, but if you prefer an explicit call for a command endpoint see [FastSpring API reference](https://developer.fastspring.com/reference/getting-started-with-your-api), and use [Proxy Actions](/proxy-actions).
@RajatPawar help me out. Should we mention commands. If so, -- does the phrasing of "may use Write" or use "Proxy directly" sounds good?
There was a problem hiding this comment.
@Fullstack-Hero, I have confirmed that this information should be removed entirely. Even if connector supports commands that should not be mentioned! At the moment it will add confusion to customers.
Once that is removed, add me as a reviewer and I will approve and merge it.
2 participants
Description