Skip to content

metamask#604

Open
MoatazOsman wants to merge 8 commits into
developmentfrom
metamask
Open

metamask#604
MoatazOsman wants to merge 8 commits into
developmentfrom
metamask

Conversation

@MoatazOsman
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2022

Deploy Preview for wallet-desktop-dev-test ready!

Name Link
🔨 Latest commit 7a26ae4
🔍 Latest deploy log https://app.netlify.com/sites/wallet-desktop-dev-test/deploys/62a00d042a67480008d9a3c3
😎 Deploy Preview https://deploy-preview-604--wallet-desktop-dev-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MoatazOsman MoatazOsman added To Review wait for review Required Translations Missing translations labels May 30, 2022
@MoatazOsman MoatazOsman requested a review from cristianizzo May 30, 2022 13:13
Comment thread src/app/services/metamask.service.ts Outdated
return from(detectEthereumProvider()).pipe(
switchMap(async (provider) => {
if (!provider) {
throw new Error('Please install MetaMask');
Copy link
Copy Markdown
Member

@cristianizzo cristianizzo Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should find a way to check if the user is in mainnet and use Ethereum

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok right, let me check the MetaMask API doc

@cristianizzo cristianizzo removed the To Review wait for review label Jun 7, 2022
@cristianizzo cristianizzo removed the Required Translations Missing translations label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants