Skip to content

User Activity improvements#1222

Open
cristianizzo wants to merge 1 commit into
developfrom
user_activity
Open

User Activity improvements#1222
cristianizzo wants to merge 1 commit into
developfrom
user_activity

Conversation

@cristianizzo
Copy link
Copy Markdown
Member

@cristianizzo cristianizzo commented Feb 9, 2022

@cristianizzo cristianizzo changed the title init User Activity improvements Feb 9, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2022

Codecov Report

Merging #1222 (06fa361) into develop (1c9edc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1222   +/-   ##
========================================
  Coverage    99.65%   99.65%           
========================================
  Files          321      321           
  Lines        10892    10894    +2     
  Branches      1570     1571    +1     
========================================
+ Hits         10854    10856    +2     
  Misses          38       38           
Impacted Files Coverage Δ
src/modules/geoLocationRiskRules.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9edc5...06fa361. Read the comment docs.

Comment thread src/modules/geoLocationRiskRules.js
type = Models.UserActivity.TYPE.HIGH_RISK_ACTIVITY;
}

return Models.UserActivity.create(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this logic

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julesGoullee here I only create the activity if it's risky as described on the Jira task. Let me know if it needs to be different
https://amontech.atlassian.net/jira/software/projects/AMNCARD/boards/2?selectedIssue=AMNCARD-135

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the logic above this function it's wired to double perform this check

type = Models.UserActivity.TYPE.HIGH_RISK_ACTIVITY;
}

return Models.UserActivity.create(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the logic above this function it's wired to double perform this check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants