User Activity improvements#1222
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1222 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 321 321
Lines 10892 10894 +2
Branches 1570 1571 +1
========================================
+ Hits 10854 10856 +2
Misses 38 38
Continue to review full report at Codecov.
|
| type = Models.UserActivity.TYPE.HIGH_RISK_ACTIVITY; | ||
| } | ||
|
|
||
| return Models.UserActivity.create( |
There was a problem hiding this comment.
I'm not sure about this logic
There was a problem hiding this comment.
@julesGoullee here I only create the activity if it's risky as described on the Jira task. Let me know if it needs to be different
https://amontech.atlassian.net/jira/software/projects/AMNCARD/boards/2?selectedIssue=AMNCARD-135
There was a problem hiding this comment.
check the logic above this function it's wired to double perform this check
| type = Models.UserActivity.TYPE.HIGH_RISK_ACTIVITY; | ||
| } | ||
|
|
||
| return Models.UserActivity.create( |
There was a problem hiding this comment.
check the logic above this function it's wired to double perform this check
2 participants
Task
https://amontech.atlassian.net/jira/software/projects/AMNCARD/boards/2?selectedIssue=AMNCARD-135