Fix report transition and screenshot extension#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.jpgso its extension matches its JPEG encoding.Root cause
The landing page scroll position persisted when React switched to the report because the ready-state transition did not reset the document scroll. The screenshot contained JPEG bytes but used a
.pngfilename.Impact
The report heading is visible as soon as analysis completes on desktop and mobile, and the README now serves the screenshot with the correct file type. Profiling calculations and interface design are unchanged.
Validation
npm run formatnpm run lintnpm run typechecknpm testwith 26 passing testsnpm run test:e2ewith 4 passing Playwright testsnpm run build