fix: consistent device ID derivation in invite/listen - #16
Merged
Conversation
invite and listen derived device IDs with raw base64url(pubkey) while init used SHA-256(pubkey). The relay matches on device ID, so the controller's allow list entry never matched the agent's registration, breaking shell routing silently (relay sends fake peer_found per C3 fix). All 4 files now use generateDeviceId() from identity.ts (SHA-256 based), matching what init produces. Existing pairings need re-pairing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inviteandlistenderived device IDs with rawbase64url(pubkey)whileinitusedSHA-256(pubkey)— the relay could never match controller's allow list entry to the agent's registration, silently breaking shell routinggenerateDeviceId()fromidentity.ts(SHA-256 based)Changes
packages/cli/src/commands/invite.ts— usegenerateDeviceId()packages/cli/src/commands/listen.ts— usegenerateDeviceId()packages/agent/src/commands/invite.ts— usegenerateDeviceId()packages/agent/src/commands/listen.ts— usegenerateDeviceId()Test plan
amesh shell testpi -c "whoami"succeeds end-to-end🤖 Generated with Claude Code