Update uncrustify version selection to support >= 0.78.1 (backport #581)#582
Merged
Conversation
Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> (cherry picked from commit b739a19)
Contributor
|
CI for this is in ros2/launch_ros#541 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Uncrustify version selection logic in
ament_uncrustifyto support versions>= 0.78.1.The Problem
Currently,
ament_uncrustifyhardcodes a check for exactly0.78.1. If the version differs (even if it is newer), the script falls back to the obsolete0.72configuration (designed for RHEL 8 / Ubuntu 20.04).0.80.1 != 0.78.1, RHEL 10 currently falls back to the0.72configuration, resulting in thousands of formatting violations in CI.The Fix
Updated the logic to use the
0.78configuration for any version>= 0.78.1. This ensures that the modern style definition is used for the 0.8x family of engines available on RHEL 10 and newer Ubuntu releases.Assisted-by: Gemini CLI:2.0-Flash
This is an automatic backport of pull request #581 done by [Mergify](https://mergify.com).