Skip to content

depr: tn1 retirement#1307

Merged
virajvchaudhari merged 2 commits into
mainfrom
rmshaffer/tn1-retirement
Jun 26, 2026
Merged

depr: tn1 retirement#1307
virajvchaudhari merged 2 commits into
mainfrom
rmshaffer/tn1-retirement

Conversation

@rmshaffer

Copy link
Copy Markdown
Member

Issue #, if available:

Description of changes:
TN1 will be retired on 2026-06-26. Preparing the corresponding SDK changes here.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer rmshaffer marked this pull request as ready for review June 25, 2026 14:45
@rmshaffer rmshaffer requested a review from a team as a code owner June 25, 2026 14:45
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a9cc73a) to head (1fd5cf6).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1307   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          171       171           
  Lines        11403     11401    -2     
  Branches      1481      1480    -1     
=========================================
- Hits         11403     11401    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

class _Amazon(StrEnum):
SV1 = "arn:aws:braket:::device/quantum-simulator/amazon/sv1"
TN1 = "arn:aws:braket:::device/quantum-simulator/amazon/tn1"
_TN1 = "arn:aws:braket:::device/quantum-simulator/amazon/tn1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why private rather than removed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently the pattern for all retired devices in this file. The idea is that this would prevent retired devices from showing up in API docs or IDE autocomplete, but still keep a visible record in case users were relying on it. Open to other suggestions though; probably we shouldn't just accumulate these forever.

@virajvchaudhari

Copy link
Copy Markdown
Contributor

Before we merge this we would also have to account for example notebooks or any other tests using this.

@rmshaffer

Copy link
Copy Markdown
Member Author

Before we merge this we would also have to account for example notebooks or any other tests using this.

The example notebooks have been updated and merged, see: amazon-braket/amazon-braket-examples#933

@virajvchaudhari virajvchaudhari merged commit ac77218 into main Jun 26, 2026
21 checks passed
@virajvchaudhari virajvchaudhari deleted the rmshaffer/tn1-retirement branch June 26, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants