Conversation
`ProgramSet.split` takes in a `max_excutables` parameter, so that the generated program sets will contain at most that many executables. Also fixed coverage output when running `tox`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 170 170
Lines 11011 11214 +203
Branches 1413 1450 +37
==========================================
+ Hits 11011 11214 +203 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sesmart
reviewed
May 7, 2026
sesmart
left a comment
sesmart
left a comment
Contributor
There was a problem hiding this comment.
Very cool 😄, just some notes on usability. Any reason the input_set is taken as the major counting index before observables? Just coincidence of orderings?
yitchen-tim
reviewed
May 7, 2026
yitchen-tim
reviewed
May 7, 2026
yitchen-tim
reviewed
May 7, 2026
speller26
changed the title
Will move to separate PR
speller26
changed the title
5 tasks
Member
Author
|
Results merging has been moved to #1254 |
5 tasks
sesmart
reviewed
Jun 8, 2026
Member
Author
|
Do not review program_set_quantum_task_result.py and test_program_set_quantum_task_result.py; those were approved in #1254 (I promise not to touch them). |
sesmart
approved these changes
Jun 19, 2026
sesmart
left a comment
sesmart
left a comment
Contributor
There was a problem hiding this comment.
Just a small tweak in the description. Otherwise looks good!
Comment on lines
+196
to
+197
| Each block is a contiguous run of executables that share the same | ||
| ``(circuit, observable list/Sum Hamiltonian, single parameter assignment)`` and can thus be |
Contributor
There was a problem hiding this comment.
Suggested change
| Each block is a contiguous run of executables that share the same | |
| ``(circuit, observable list/Sum Hamiltonian, single parameter assignment)`` and can thus be | |
| Each block is a contiguous run of executables generated from the same | |
| ``(circuit, observable list/Sum Hamiltonian, single parameter assignment)`` and can thus be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
splitmethod toProgramSetto split program set into a list of program sets each with at most an allowed number of executables.Also fixed coverage output when running
tox.Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.