Skip to content

ADO 108387: ESM export support#79

Merged
Nick Abboud (nabboud-ama) merged 24 commits into
masterfrom
ado-108387-esm-package-support
Feb 17, 2026
Merged

ADO 108387: ESM export support#79
Nick Abboud (nabboud-ama) merged 24 commits into
masterfrom
ado-108387-esm-package-support

Conversation

@nabboud-ama
Copy link
Copy Markdown
Contributor

@nabboud-ama Nick Abboud (nabboud-ama) commented Feb 11, 2026

Is this PR a bug fix, new feature, or security update?

New feature

Do you understand and accept that your contribution will be released under an MIT license?

Yes

Please describe this pull request:

Tech updates:

  • ESM support, on top of the existing CommonJS support
  • TypeScript set up to support ESM
  • ESLint update
  • Prettier installed
  • Removed the old tests for Node 18

Functional updates:

  • "credit" removed from the default filter list.

Test via the nick branch from this PR: https://github.com/amaabca/react-kart/pull/3460

  • The dev branch is being imported here.
  • Run a smoke test using a gift card (e.g. Cineplex $25).
  • You can check two lambdas that use different import methods in this PR to confirm sensitive-param-filter works in both cases.

PR Review Checklist

  • I have passing tests run via npm run test with a 100% coverage threshold
  • I have updated the version in package.json
  • I have updated any relevant documentation in README.md, .github, etc.
  • I have not included any secret values or links to internal AMA URLs in my commits or PR message

@nabboud-ama Nick Abboud (nabboud-ama) marked this pull request as ready for review February 11, 2026 21:48
@nabboud-ama Nick Abboud (nabboud-ama) requested a review from a team as a code owner February 11, 2026 21:48
Comment thread src/sensitiveParamFilter.js Outdated
@MathieuGilbert Mathieu Gilbert (MathieuGilbert) force-pushed the ado-108387-esm-package-support branch 2 times, most recently from b61be53 to b3d5ad7 Compare February 13, 2026 00:32
@MathieuGilbert
Copy link
Copy Markdown
Member

Last deploy only failed due to rolling back a commit/version.

Comment thread README.md Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread package.json
{
"name": "@amaabca/sensitive-param-filter",
"version": "1.2.12",
"version": "1.3.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nabboud-ama Nick Abboud (nabboud-ama) merged commit af4057a into master Feb 17, 2026
14 checks passed
@nabboud-ama Nick Abboud (nabboud-ama) deleted the ado-108387-esm-package-support branch February 17, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants