Plugin check compliance#13
Open
MahamadSayed wants to merge 7 commits into
Open
Conversation
…ning Add a minimal phpcs.xml.dist ruleset that excludes lib/ (composer vendor-dir per composer.json) so `wp plugin check` and PHPCS stop reporting unfixable third-party errors from vendored dependencies. lib/ is intentionally NOT added to .distignore - it is required at runtime and must ship with the plugin. The new ruleset is added to .distignore so the dev lint config is not published to the wordpress.org SVN, consistent with the existing phpcs.ruleset.xml / phpunit.xml.dist entries. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…s.DateTime compliance
…dPress.WP.AlternativeFunctions
…ata() to satisfy WordPress.DB
…on() Wrap the "Cannot open <$zip_path>" exit string with esc_html() to satisfy WordPress.Security.EscapeOutput, which treats die()/exit() string output as output requiring escaping when it interpolates a dynamic value. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…andler The @mkdir() call in handle_import_action() tripped WordPress.WP.AlternativeFunctions.file_system_operations_mkdir. Use the core wp_mkdir_p() wrapper instead, which is not flagged by the sniff and already returns true when the directory exists or is successfully created, making the surrounding is_dir() guards redundant. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the errors from #12