Feature/song genres#6
Merged
Merged
Conversation
Show GenreBadge between artist and "Added by" when song has a genre. Add SongCard component tests for genre badge rendering.
Add topGenre field to PastRound interface and render GenreBadge in past rounds cards below the song/artist info.
Build artifacts in android/ were being linted unnecessarily. console.error in catch blocks is legitimate error logging, not debug noise.
Substring matching caused false positives ("popular" matched "pop",
"countryside" matched "country"). Replaced with explicit aliases for
common Last.fm tag variants. Added tests for false-positive scenarios.
LASTFM_API_KEY is not exposed to client bundles (no PUBLIC_ prefix). Genre detection was dead code in production. Now the server endpoint detects genre and includes it as _detectedGenre in the response.
Validate genre against GENRES whitelist before Supabase insert to prevent arbitrary strings. Add LASTFM_API_KEY to env validation schema.
- Add PastRounds tests (genre badge, empty state, scores, locale) - Add SongCard tests (title/artist render, "Your track" state) - Fix test assertions: toBeDefined -> toBeInTheDocument - Fix test name: "capitalize" -> "render as-is" for unknown genres - Replace loop with it.each in lastfm hip-hop variants - Use GENRES.length instead of magic number 20 - Change odesli mock default to null for neutral behavior
✅ Deploy Preview for aux-music ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Resolve 9 conflicts from feature/android-capacitor merge: - Combine expanded eslint ignores with no-console rule - Merge capacitor deps with user-event dev dependency - Add genre detection to server-side resolve with rate limiter - Add topGenre to PastRound interface in useLeaderboard - Add GenreBadge to expandable PastRounds component - Add GenreFilter to tabbed LeaderboardView - Add genre field to test factories (SongCard, useLeaderboard) - Update AddSong tests for genre-aware signature - Regenerate pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.