Feature/android capacitor#4
Merged
Merged
Conversation
Cover valid platform URLs (Spotify, YouTube, Apple Music, Tidal, Deezer, SoundCloud, song.link, album.link, odesli.co), invalid/missing URL params, unsupported platforms, protocol enforcement (HTTPS only), Odesli API error forwarding (404, 500), network failures (502), and Content-Type header.
Reusable rate limiter with configurable max requests and window duration. Prunes expired timestamps per key and runs periodic cleanup to prevent unbounded memory growth. Includes 8 unit tests.
useMember: member loading from localStorage, supabase fetch, null handling for missing/invalid IDs. useGroup: initialization, error states, addSong/voteSong guards (no round, no member, rating bounds), songsPerRound default of 3, initial members prop. useLeaderboard: stats calculation (totalScore, avgReceived, songsAdded, roundsWon), sorting by totalScore, pastRounds summary, current round exclusion from wins.
…endpoint Apply 10 req/min per-IP rate limiting to GET /api/resolve using the sliding window rate limiter. Extract client IP from X-Forwarded-For (Netlify). Return 429 with Retry-After header when exceeded. Also guard against oversized upstream responses (>512 KB). Tests updated with rate limiter mock and new assertions for 429 and size guard.
StarRating: read-only vs interactive mode, half-star precision, aria labels, button click callbacks for all 0.5-5.0 increments. SongCard: title/artist rendering, added-by display, thumbnail HTTPS enforcement, own-track vs other-track rating, average rating display, platform links, album art alt text. AddSong: input enable/disable, submit with trimmed URL, clear on success, error feedback, resolving state, whitespace-only rejection. JoinGroup: member selection flow, create member form, name validation, emoji picker, back navigation, member ID storage on selection.
Cover storage XSS prevention (script tags, URL-encoded payloads, path traversal, HTML entities, SQL injection in member IDs), URL validation (javascript:/data:/file: protocols, HTTP rejection, non-music domains, embedded credentials), title truncation to prevent storage abuse, HTTPS-only enforcement for platform links and thumbnails.
Required for component and hook tests with jsdom environment.
✅ Deploy Preview for aux-music ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.