WPI/ENH: Match __init__ signature

[bashtage]

Match signature of property

[bashtage]

This is not complete, but I wanted to see if you support matching properties sig. This caught me out since I have a metaclass that checks for properties and then reinitializes them. The call to cached_property is different and so rather than have

if isinstance(attr, property):
    attr.__class__(attr.fset, attr.fget, attr.fdel, attr.__doc__)

I have to special case cached_property. I believe this is called the Liskov substitution principle.

[althonos]

Wonderful, thank you. Is it clear to merge or do you want to change some more things?

[bashtage]

It needs more work to make the interface of them all the same, and a test or two.

…

On Sun, Sep 15, 2019, 13:25 Martin Larralde ***@***.***> wrote: Wonderful, thank you. Is it clear to merge or do you want to change some more things? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=ABKTSRLWG2PKPREEF6XNDADQJYSUJA5CNFSM4IWYEYCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XPXFY#issuecomment-531561367>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKTSRKIYBKNDZE4YVZM5LTQJYSUJANCNFSM4IWYEYCA> .