Skip to content

Remove Python 2 support#25

Merged
althonos merged 5 commits into
althonos:forkfrom
Seanny123:no-py2
Mar 6, 2020
Merged

Remove Python 2 support#25
althonos merged 5 commits into
althonos:forkfrom
Seanny123:no-py2

Conversation

@Seanny123

Copy link
Copy Markdown

Although explicitly unsupported, there was still some code hanging around for Python 2, which is removed in this PR.

@codecov

codecov Bot commented Mar 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #25 into fork will increase coverage by 5.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             fork       #25      +/-   ##
===========================================
+ Coverage   94.23%   100.00%   +5.76%     
===========================================
  Files           1         1              
  Lines         104        95       -9     
===========================================
- Hits           98        95       -3     
+ Misses          6         0       -6     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ffba9...3027718. Read the comment docs.

@althonos althonos merged commit 108d189 into althonos:fork Mar 6, 2020
@althonos

althonos commented Mar 6, 2020

Copy link
Copy Markdown
Owner

Good catch, thanks. I will post a new release ASAP.

@althonos althonos added the enhancement New feature or request label Mar 6, 2020
@Seanny123

Copy link
Copy Markdown
Author

@althonos did you know Python has built-in support for cached_property? Does this built-in support make parts of this project obsolete?

@althonos

Copy link
Copy Markdown
Owner

@Seanny123 : the Python cached_property comes from the cached-property library, which this repo is a fork of, fixing a lot of bugs back from the Python 3.6 era. The builtin version has been incorporated as it, which means it still has the quirks of the original version. Most notably, functools.cached_property does not derive from property, which has some unfortunate side effect with some libraries.

Check out the original (and very much ignored) pull request here: pydanny#137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants