Skip wait between tests if iterations are exhausted#65
Merged
Conversation
danopolan
requested review from
Meenakshi2000,
jmfiola,
sharmi-saha,
sistratton and
skezell
as code owners
June 26, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to skip wait time at the end of the test iteration defined by
between(min_wait, max_wait)in case iterations are exhausted.Curently:
If you test takes 30 seconds to execute, but you run users:1, iterations:1, runtime:600, min_wait:601 the test will end after 600 seconds, not after 30s.
That is because iterations are increased at the end of a test, but evaluated at the start of next test. Wait is applied at the end of the iteration. So test single iteration time is 30(test) + 601(wait), which is gt 600(runtime) and so it will time out.
Newly:
Iterations are increased at the end of the test, then wait is applied, then iterations limit is checked at the start of the next test. But in case iterations are exhausted, wait is skipped.