fix: stream records via /zone/{origin}/_stream - #1
Merged
Conversation
The real API keys the stream endpoint by origin alone and returns
404 for the /zone/{origin}/{virtualNameServer}/_stream path both the
client and fakeautodns used (verified against api.autodns.com on
2026-07-20; fake and client agreed with each other, so no test
caught it).
StreamRecords drops its now-unused virtualNameServer parameter, an
API change allowed at v0.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
StreamRecordsposts to/zone/{origin}/{virtualNameServer}/_stream, but the real API keys the stream endpoint by origin alone: that path returns 404 on api.autodns.com (verified 2026-07-20 with a probe TXT record on a live zone).fakeautodnsimplemented the same wrong route, so the client and fake agreed with each other while both disagreed with production - no test caught it.Fix
client.StreamRecordsposts to/zone/{origin}/_streamand drops the now-unusedvirtualNameServerparameter (API change, allowed at v0.x).fakeautodnsserves the corrected origin-only route; its stream handler applies the stream to every stored zone with the given origin.Verification
POST /zone/{origin}/_stream(no vns segment) against api.autodns.com on a live zone: HTTP 200,S0202002- add and remove of a probe TXT record both succeeded.make testandmake lintgreen.