Added an option to not format headings as links#348
Conversation
059b10c to
77b4c2b
Compare
|
Is this PR rejected? |
If it were rejected, it would be rejected. This is the first time I've seen it. @OZoneGuy Feel free to ping me on PRs that go unnoticed for a while. I have a lot of projects on here and it's easy to miss notifications. I'll submit some feedback as a review. |
|
Sorry, but I will have to ask you to disentangle this and #349, as they both contain some of the same changes. Magit should make it easy enough; I'd suggest making a new branch and cherry-picking the changes, then pushing the new branch to this PR's reference. |
|
@alphapapa, both PRs are untangled now. I will rebase the one that gets merged in last if there are any merge conflicts. PTAL |
|
CC @alphapapa |
|
|
||
| :not-links Optional boolean. If non-nil, don't make headings | ||
| into links. | ||
| :link Optional flag. Defaults to `t`. When non-nil, links |
There was a problem hiding this comment.
+1 I was going to suggest this but see you already made that change.
|
@alphapapa pinging since you said to if it's been a while. |
|
Thanks for implementing this feature, I tested it locally and works perfectly. |
|
Thanks for the reminder. For consistency with Org's clock table dynamic blocks, we should probably name the property |
Added
:not-linksto the dynamic block options to allow creating the table without having the headings as links.Example:
Related to #330