Skip to content

Added an option to not format headings as links#348

Open
OZoneGuy wants to merge 4 commits into
alphapapa:masterfrom
OZoneGuy:master
Open

Added an option to not format headings as links#348
OZoneGuy wants to merge 4 commits into
alphapapa:masterfrom
OZoneGuy:master

Conversation

@OZoneGuy

@OZoneGuy OZoneGuy commented Apr 19, 2023

Copy link
Copy Markdown

Added :not-links to the dynamic block options to allow creating the table without having the headings as links.

Example:

#+BEGIN: org-ql :query (todo \"UNDERWAY\")
:columns (priority todo heading) :sort (priority date)
:ts-format \"%Y-%m-%d %H:%M\" :not-links t

Related to #330

This was referenced Apr 19, 2023
@alphapapa alphapapa force-pushed the master branch 2 times, most recently from 059b10c to 77b4c2b Compare December 16, 2023 13:55
@TomoeMami

Copy link
Copy Markdown

Is this PR rejected?

@alphapapa

Copy link
Copy Markdown
Owner

Is this PR rejected?

If it were rejected, it would be rejected. This is the first time I've seen it.

@OZoneGuy Feel free to ping me on PRs that go unnoticed for a while. I have a lot of projects on here and it's easy to miss notifications.

I'll submit some feedback as a review.

@alphapapa alphapapa left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment thread org-ql-search.el Outdated
Comment thread org-ql-search.el Outdated
Comment thread org-ql-search.el Outdated
@alphapapa alphapapa added this to the 0.9 milestone Jan 5, 2024
@alphapapa alphapapa linked an issue Jan 5, 2024 that may be closed by this pull request
@OZoneGuy OZoneGuy requested a review from alphapapa January 7, 2024 23:22
@alphapapa

Copy link
Copy Markdown
Owner

Sorry, but I will have to ask you to disentangle this and #349, as they both contain some of the same changes. Magit should make it easy enough; I'd suggest making a new branch and cherry-picking the changes, then pushing the new branch to this PR's reference.

@OZoneGuy

OZoneGuy commented Jan 8, 2024

Copy link
Copy Markdown
Author

@alphapapa, both PRs are untangled now. I will rebase the one that gets merged in last if there are any merge conflicts. PTAL

@OZoneGuy

OZoneGuy commented Feb 4, 2024

Copy link
Copy Markdown
Author

CC @alphapapa

Comment thread org-ql-search.el

:not-links Optional boolean. If non-nil, don't make headings
into links.
:link Optional flag. Defaults to `t`. When non-nil, links

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I was going to suggest this but see you already made that change.

@nickanderson

Copy link
Copy Markdown

@alphapapa pinging since you said to if it's been a while.

@maikol-solis

Copy link
Copy Markdown

Thanks for implementing this feature, I tested it locally and works perfectly.

@alphapapa

Copy link
Copy Markdown
Owner

Thanks for the reminder.

For consistency with Org's clock table dynamic blocks, we should probably name the property :link and use :link nil to disable the links. See (info "(org) The clock table").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use links in dynamic block

5 participants