Skip to content

If the response is not 200 then raise an exception#19

Merged
kentsanggds merged 5 commits into
mainfrom
raise-error-non-200-response
Jul 15, 2026
Merged

If the response is not 200 then raise an exception#19
kentsanggds merged 5 commits into
mainfrom
raise-error-non-200-response

Conversation

@kentsanggds

Copy link
Copy Markdown
Collaborator

The contact was silently failing on non 200 error responses leading to obscure error messages that are related to parsing the error response and not the content.

So let the publisher know that the request failed with the status code

https://cddodatamarketplace.atlassian.net/jira/software/c/projects/DGUK/boards/727?selectedIssue=DGUK-763

@kentsanggds
kentsanggds requested a review from a team July 14, 2026 09:26
@kentsanggds
kentsanggds force-pushed the raise-error-non-200-response branch 2 times, most recently from 94942e4 to b2408a4 Compare July 15, 2026 14:33
Comment thread .github/workflows/test.yml Outdated
The contact was silently failing on non 200 error responses leading to obscure error messages that are related to parsing the error response and not the content.
@kentsanggds
kentsanggds force-pushed the raise-error-non-200-response branch from aac47ee to 7874e12 Compare July 15, 2026 15:08
@kentsanggds
kentsanggds merged commit 92e0397 into main Jul 15, 2026
7 checks passed
@kentsanggds
kentsanggds deleted the raise-error-non-200-response branch July 15, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants