fix(ingest): strip GitHub deep links before git clone#215
Open
MohammedAnasNathani wants to merge 1 commit into
Open
fix(ingest): strip GitHub deep links before git clone#215MohammedAnasNathani wants to merge 1 commit into
MohammedAnasNathani wants to merge 1 commit into
Conversation
Pasted browser URLs like .../tree/main/examples passed validation then died with a raw git error. Recognize GitHub /tree and /blob suffixes, clone the repository root, and warn. GitLab subgroup paths stay intact. Closes alphacrack#109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #109.
Pasting a browser deep link (
…/tree/main/examples,…/blob/main/README.md) is a common first-run mistake._URL_REaccepted it (GitLab subgroups need extra segments), thengit clonefailed with a raw non-zero-exit message.Fix
_normalize_clone_url()recognizes GitHub deep-link markers (tree,blob, …)UserWarningnoteTests
clone_repoargv uses the stripped root (monkeypatched subprocess)Test plan
pytest tests/test_ingest.py -k "deep_link or gitlab or normalize"