refactor: extract DSL escaping helpers into escaping.py#210
Open
MohammedAnasNathani wants to merge 1 commit into
Open
refactor: extract DSL escaping helpers into escaping.py#210MohammedAnasNathani wants to merge 1 commit into
MohammedAnasNathani wants to merge 1 commit into
Conversation
Move DistillError, _grep_flags_and_pattern, _VHS_REGEX_METAS, vhs_wait_pattern, and vhs_quote into a new module and re-export them from distill so existing imports keep working. Zero behavior change; grounding code stays in distill.py. Closes alphacrack#195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #195 (first zero-behavior slice of #59).
Moves exactly five symbols out of
distill.pyintoescaping.py:DistillErrorvhs_quoteraises it)_grep_flags_and_pattern(?i)→grep -qiE_VHS_REGEX_METASvhs_wait_patternvhs_quotedistill.pyre-exports them with# noqa: F401so every existingfrom readme2demo.distill import …keeps working. No groundinghelpers moved. No test file edits. No behavior changes.
Test plan
pytest tests/test_distill.py— 47 passedruff check src/readme2demo/escaping.py src/readme2demo/distill.pycleanescaping.pydoes not importdistill(no cycle)