Add Maithili language README.maithili.md#49
Conversation
alphacrack
left a comment
There was a problem hiding this comment.
This is exactly the kind of contribution #11 hoped for — धन्यवाद! 🙏 The structure mirrors the English README section-for-section and most of it reads naturally. A few things to fix before merge:
Objective content errors (must fix):
- Features list says देवनागरी अंक (
0-9) — the original (and the language!) is०-९. The Devanagari numerals are the whole point of that bullet. - Module-translation example says
गणित→गणित— should beगणित→math.
Structural (should fix):
3. The file isn't linked from README.md — #11 suggested a line at the top of the English README (e.g. [मैथिली मे पढ़ू](README.maithili.md)), otherwise nobody will find it.
4. Leftover untranslated fragments: duplicated "Clone the repo:" above the Maithili line, and the "### 🔧 Install CLI Tool (cross-platform)" heading.
5. The stray first line # README.md — the English README has the same wart, but no need to copy it here.
Coordination notes (non-blocking):
- The keyword table copies the English table's 11 rows, which is already missing 5 mappings (#39). Fine to merge as-is and let #39 update both files together — just flagging so they don't drift separately.
- For future PRs, please branch off
developmentwith a topic branch rather than PRing from your fork'sdevelopmentdirectly (see CONTRIBUTING.md) — it makes follow-up pushes cleaner.
On phrasing (मे vs में, "के साथ", "जैसे" etc.) I'll defer to native speakers — posting a pointer on #11 inviting review would be a great move. Excited to get this in!
|
अहा केत से छियाईं यौ
…On Mon, 20 Jul, 2026, 10:39 pm Bishwas Jha, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This is exactly the kind of contribution #11
<#11> hoped for —
धन्यवाद! 🙏 The structure mirrors the English README section-for-section
and most of it reads naturally. A few things to fix before merge:
*Objective content errors (must fix):*
1. Features list says देवनागरी अंक (0-9) — the original (and the
language!) is *०-९*. The Devanagari numerals are the whole point of
that bullet.
2. Module-translation example says गणित → गणित — should be *गणित →
math*.
*Structural (should fix):*
3. The file isn't linked from README.md — #11
<#11> suggested a
line at the top of the English README (e.g. [मैथिली मे पढ़ू](
README.maithili.md)), otherwise nobody will find it.
4. Leftover untranslated fragments: duplicated "Clone the repo:" above the
Maithili line, and the "### 🔧 Install CLI Tool (cross-platform)" heading.
5. The stray first line # README.md — the English README has the same
wart, but no need to copy it here.
*Coordination notes (non-blocking):*
- The keyword table copies the English table's 11 rows, which is
already missing 5 mappings (#39
<#39>). Fine
to merge as-is and let #39
<#39> update
both files together — just flagging so they don't drift separately.
- For future PRs, please branch off development with a topic branch
rather than PRing from your fork's development directly (see
CONTRIBUTING.md) — it makes follow-up pushes cleaner.
On phrasing (मे vs में, "के साथ", "जैसे" etc.) I'll defer to native
speakers — posting a pointer on #11
<#11> inviting
review would be a great move. Excited to get this in!
—
Reply to this email directly, view it on GitHub
<#49?email_source=notifications&email_token=BGUAKDXCINOGUUYNUX2XMST5FZG5BA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZTG4YTMNJVGY2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4737165564>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGUAKDUJZJ4FT4JYEQLEFVD5FZG5BAVCNFSNUABFKJSXA33TNF2G64TZHM4TOMRRGY3TIMJWHNEXG43VMU5TIOJSGM3TAMZSGI32C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
हम जनकपुरधाम सँ छी। |
Summary
Motivation / Audit Reference
Test Evidence
pytest -vruns green locallypython -m maithili_dsl examples/*.dmaismoke-tested the examplespython -m maithili_dsl --versionshows the expected versionSecurity Considerations
Breaking Changes
Checklist