feat(x/provider): lock fees_per_block denom at module wiring#54
Merged
Conversation
Contributor
Author
tbruyelle
approved these changes
Jun 5, 2026
Contributor
There was a problem hiding this comment.
LGTM
Tiny optimization: DistributeFeesToValidators() should call k.GetFeeDenom() instead of k.GetFeesPerBlock().Denom to prevent a useless params store read.
Additional note: impact the wiring in atomone-hub/atomone#283 (cc @julienrbrt)
Contributor
Author
fair point! |
Contributor
|
Just realized as well that |
tbruyelle
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Follow-up to #47.
Params.FeesPerBlock(asdk.Coin) letMsgUpdateParamssilently change the fee denom, which would break downtime slashing logic and force an upgrade of any per-consumer override.This PR removes the denom from params entirely: the amount stays a param (
Params.FeesPerBlockAmount,math.Int), while the denom is fixed at keeper construction (Keeper.feeDenom) and cannot change without a binary upgrade — satisfying the constitution's "ICS payments in PHOTON" requirement.The reference app wires
providertypes.DefaultFeesPerBlockDenomwhile AtomOne is supposed to wirephotontypes.Denom. Both resolve touphotonbut the former is less formal and just for testing purposes.NewKeeperpanics on an invalid denom.BREAKING:
Paramsproto field 5 changes fromsdk.Coinfees_per_blocktostringfees_per_block_amount.