Skip to content

Releases: alliedtelesis/netmap

974b68c0-atl-25

09 Jun 23:00

Choose a tag to compare

Fix TX stall when skipping netmapemu qdisc

Commit e6685fea679a ("Prevent tc configs from applying for generic
netmap adapter") skipped calling nm_os_catch_tx() to avoid installing
the custom netmapemu qdisc and hooking ndo_start_xmit().
However, gna->txqdisc is still set to 1 by nm_os_generic_set_features
so the tx sync path expects the qdisc to still be enabled.

Normally every mbuf sent by nm_os_generic_xmit_frame() is marked with
NM_MAGIC_PRIORITY_TX and generic_ndo_start_xmit() resets that priority
to 0 once the real driver transmits the packet.
Without the hook installed, the priority is never cleared.
generic_netmap_tx_clean() checks MBUF_QUEUED() to decide if a slot is
free and with txqdisc=1 and the priority permanently set, every slot
appears as in-use and the TX ring fills up and traffic stops.

To fix this, turn off the txqdisc flag if we are skipping qdisc setup.

e71c188-atl-7

08 Jun 03:59

Choose a tag to compare

Fix TX stall when skipping netmapemu qdisc

Commit 6d072ad3b73a ("Prevent tc configs from applying for generic
netmap adapter") skipped calling nm_os_catch_tx() to avoid installing
the custom netmapemu qdisc and hooking ndo_start_xmit().
However, gna->txqdisc is still set to 1 by nm_os_generic_set_features
so the tx sync path expects the qdisc to still be enabled.

Normally every mbuf sent by nm_os_generic_xmit_frame() is marked with
NM_MAGIC_PRIORITY_TX and generic_ndo_start_xmit() resets that priority
to 0 once the real driver transmits the packet.
Without the hook installed, the priority is never cleared.
generic_netmap_tx_clean() checks MBUF_QUEUED() to decide if a slot is
free and with txqdisc=1 and the priority permanently set, every slot
appears as in-use and the TX ring fills up and traffic stops.

To fix this, turn off the txqdisc flag if we are skipping qdisc setup.

e71c188-atl-6

19 May 01:58

Choose a tag to compare

mvpp2: Keep irqs_enabled in sync with interrupt status

If interrupts were disabled prior to an admin down/up, irqs_enabled
will be out of sync with the interrupt status when the interface
comes back up. This is now corrected when processing an interrupt.

974b68c0-atl-24

21 Apr 05:06

Choose a tag to compare

What's Changed

  • Prevent tc configs from applying for generic netmap adapter by @Angela246 in #57

Full Changelog: 974b68c0-atl-23...974b68c0-atl-24

e71c188-atl-5

13 Apr 21:04

Choose a tag to compare

What's Changed

  • Prevent tc configs from applying for generic netmap adapter by @Angela246 in #56

New Contributors

Full Changelog: e71c188-atl-4...e71c188-atl-5

e71c188-atl-4

29 Aug 02:28

Choose a tag to compare

What's Changed

Full Changelog: e71c188-atl-3...e71c188-atl-4

e71c188-atl-3

27 May 19:09

Choose a tag to compare

e71c188-atl-2

27 May 03:04

Choose a tag to compare

e71c188-atl-1

27 May 01:34

Choose a tag to compare

19a7eb6a-atl-1

17 Feb 21:56

Choose a tag to compare