Avoid leaking vecs#3
Open
nappa85 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids using Vecs and then leaking it.
Storage is initialized in a const fashion when creating the allocator, and will live in the same static address, not on the heap. This should increase performances, but I have no benchmarks to demonstrate it (I also understand that performances is not a main goal of this allocator).
I've noticed a logic flaw, and I want to discuss it with you:
start_track, but not resettingallocation_logs_pointeranddeallocation_logs_pointer, thus if someone would have calledstart_trackmultiple times (obviously respecting the safety guarantees of never calling it concurrently) he could have received the overflow panic even if the buffer wasn't really fullstart_trackmultiple times will always keep previous run in memoryA third behavior could be implemented, if desired, emptying the storage and resetting the counters, to allow multiple indepentent runs.
Unrelated, but I would also suggest to use
clippywhile developing, I've took the initiative to apply some clippy lints on first commit.