Skip to content

fix: secret span offsets use line number not find() #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: secret span offsets use line number not find() #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/dolma/taggers/code/code_taggers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ def _extract_code_secrets(cls, text: str) -> List[Span]:
line_number = secret.line_number - 1
span = secret.secret_value
span_line = text_lines[line_number]
line_start = text.find(span_line)
# Index by line number — find() hits the first duplicate line content.
line_start = sum(len(l) + 1 for l in text_lines[:line_number])
start = line_start + span_line.find(span or "")
end = start + len(span or "")
assert text[start:end] == span
Expand Down