fix(tokenizer): honor max_size bytes and default files_per_process#303
Open
Chessing234 wants to merge 1 commit into
Open
fix(tokenizer): honor max_size bytes and default files_per_process#303Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
- Default files_per_process to 1 to match documented behavior - Convert max_size bytes to memmap token capacity by dtype width - Write token slices consistently and fail on oversized sequences - Guard against unbounded memmap rollover loops Fixes allenai#272 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files_per_processto1to match documented tokenization behaviormax_size(bytes) to memmap token capacity using the configured dtype widthtokens[start:end]consistently inMemmapWriterand error on sequences larger than a memmap fileFixes #272
Test plan
dolma tokenson a small sample with--processes 2 --files_per_process 1and confirm output file count matches expectations--max_sizeset and verify memmap files respect the byte limitMade with Cursor