Add Gardena mower protocol features#148
Open
AlirezaT wants to merge 2 commits into
Open
Conversation
alistair23
approved these changes
Jun 16, 2026
alistair23
reviewed
Jun 16, 2026
| """Send a command while the caller already holds the BLE command lock.""" | ||
| command = Command(self.channel_id, (await self.get_protocol())[command_name]) | ||
| request = command.generate_request(**kwargs) | ||
| response = await self._request_response_locked(request) |
Owner
There was a problem hiding this comment.
Do we really need a lock here?
Owner
|
Sorry about the long delay! Overall this looks good. It does need a rebase and the ruff CI tests need to pass. It would be great (although not required) if you could split the PR up into some smaller independent PRs. That way if something breaks it's easy to figure out exactly what change causes the breakage. I'm also not clear on why we need Can you provide a few more details? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the generic Automower/Gardena BLE protocol work from the Home Assistant Gardena BLE integration back into the Python library.
Included:
Notes:
Validation: