Reject negative rate limit costs#362
Open
carlok wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the contribution! You can fix most linting errors by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi Ali-Akber, first of all thank you for maintaining
limits.I noticed that negative
costvalues are currently not rejected before strategy evaluation. With the in-memory fixed-window and sliding-window-counter strategies, passingcost=-1can increase the apparent remaining quota instead of consuming it.This PR adds a small shared validation step in the sync and async
RateLimiterbase classes and applies it consistently beforehit()/test()strategy logic.The change deliberately preserves the existing
cost=0no-op behavior and only rejectscost < 0.What changed
costvalues withValueErrorFixedWindowRateLimiterMovingWindowRateLimiterSlidingWindowCounterRateLimiterLocal verification