Skip to content

fix: repair AWS private manager handoff permissions #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alongubkin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: repair AWS private manager handoff permissions #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 38 additions & 4 deletions crates/alien-permissions/permission-sets/compute-cluster/management.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@
// launch templates. That authorization check covers every EC2 resource
// referenced by the template and ASG placement, not only the template.
{
"label": "Use runtime launch templates",
"grant": {
"actions": ["ec2:RunInstances"]
},
"binding": {
"stack": {
"resources": [
"arn:aws:ec2:${awsRegion}:${awsAccountId}:launch-template/*",
"arn:aws:ec2:${awsRegion}:${awsAccountId}:security-group/*"
"arn:aws:ec2:${awsRegion}:${awsAccountId}:launch-template/*"
],
"condition": {
"StringEquals": {
Expand All @@ -77,8 +77,7 @@
},
"resource": {
"resources": [
"arn:aws:ec2:${awsRegion}:${awsAccountId}:launch-template/*",
"arn:aws:ec2:${awsRegion}:${awsAccountId}:security-group/*"
"arn:aws:ec2:${awsRegion}:${awsAccountId}:launch-template/*"
],
"condition": {
"StringEquals": {
Expand All @@ -89,6 +88,41 @@
}
}
},
// The ComputeCluster security group is setup-owned boundary
// infrastructure. Runtime may use it to launch workers, but may not
// mutate or delete it through this permission.
{
"label": "Use setup compute security groups",
"grant": {
"actions": ["ec2:RunInstances"]
},
"binding": {
"stack": {
"resources": [
"arn:aws:ec2:${awsRegion}:${awsAccountId}:security-group/*"
],
"condition": {
"StringEquals": {
"aws:ResourceTag/${stackTag}": "${stackPrefix}",
"aws:ResourceTag/${managedByTag}": "setup",
"aws:ResourceTag/${resourceTag}": "compute"
}
}
},
"resource": {
"resources": [
"arn:aws:ec2:${awsRegion}:${awsAccountId}:security-group/*"
],
"condition": {
"StringEquals": {
"aws:ResourceTag/${stackTag}": "${stackPrefix}",
"aws:ResourceTag/${managedByTag}": "setup",
"aws:ResourceTag/${resourceTag}": "compute"
}
}
}
}
},
{
"grant": {
"actions": ["ec2:RunInstances"]
Expand Down
Loading
Loading